[PATCH 1 of 5 V5] dirstate: rename the dirstate parsing and packing methods

Matt Mackall mpm at selenic.com
Fri Dec 18 17:02:14 CST 2015


On Thu, 2015-12-17 at 15:44 -0800, Laurent Charignon wrote:
> # HG changeset patch
> # User Laurent Charignon <lcharignon at fb.com>
> # Date 1450380353 28800
> #      Thu Dec 17 11:25:53 2015 -0800
> # Node ID 44eafafb98c9d24bdff7d6c46213ffe2cf8edc8d
> # Parent  7e8a883da1711008262150bb6f64131812de3e0b
> dirstate: rename the dirstate parsing and packing methods

Explodes my hg on apply. The pure/ code is not available for fallback
unless the C module doesn't exist at all, fallback doesn't happen on a
function by function basis.

Consider this strategy:

- don't touch parse_dirstate
- don't touch the read/write methods
- add a simple Python func (in dirstate, not pure) to build
nonnormalmap from map
- attach this to a propertycache so we only build it when needed
- add a C version of that function in parsers
- add a clause in Python function to call C function if available

Something else to consider: it might be better for nonnormalmap to be a
set?

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial-devel mailing list