[PATCH 1 of 6] verify: move verify logic into a class

[Durham Goode]

Look at it with diff -w.  It's only a few lines of change with that.

On Dec 19, 2015 10:14 AM, Sean Farley <sean at farley.io> wrote:

Durham Goode <durham at fb.com> writes:

> # HG changeset patch
> # User Durham Goode <durham at fb.com>
> # Date 1450485759 28800
> #      Fri Dec 18 16:42:39 2015 -0800
> # Node ID 8d978bb49549a93197ad5748f218cdf19ded6fb9
> # Parent  ff305ab2e0d7291da12a8b640ce8c9bb28e0cb03
> verify: move verify logic into a class
>
> In order to allow extensions to hook into the verification logic more easily, we
> need to refactor it into multiple functions. The first step is to move it to a
> class so the shared state can be more easily accessed.

I don't know about others but there is no way I can read this patch. The
usual approach is to add a bare class, copy methods over, have code call
the new class, then remove dead code. Though, that's just mainly for my
own sanity in reviewing.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20151219/2115c187/attachment.html>