[PATCH 1 of 5 V5] dirstate: rename the dirstate parsing and packing methods

[Durham Goode]

On 12/19/15, 9:34 AM, "Laurent Charignon" <lcharignon at fb.com> wrote:

>
>> On Dec 19, 2015, at 12:44 AM, Laurent Charignon <lcharignon at fb.com> wrote:
>> 
>> Thanks Matt and Yuya! I will benchmark it on the same repo as Durham to see the numbers because it seems to contradict the order of magnitude that Durham had. I will send a V6 next week.
>
>Thanks Yuya for the Pro-Tip to quickly benchmark an individual function, I had no idea how to do that well before.
>
>I can reproduce Durham's number on our large repos with Yuya's python code: ~350ms for building the map.
>However, it looks like computing the non-normal map in C on the same big repo would cost ~20ms, that's a big win, so, I will follow Matt's plan!

Any idea why it's so much cheaper to build the non-normalmap than the entire dirstate?  It's iterating over the same data right?  Perhaps it's because we're building a smaller collection (in which case, are we pre-sizing the dict correctly when building the dirstate?)