[PATCH 05 of 10 PyPy] histedit: don't bother with cPickle, demand-load pickle

[Augie Fackler]

On Mon, Dec 28, 2015 at 01:20:39AM +0900, Yuya Nishihara wrote:
> On Wed, 23 Dec 2015 16:22:20 -0800, Bryan O'Sullivan wrote:
> > We're unlikely to ever need the pickle module, so there's no good
> > reason to force loading of its faster cousin.
> >
> > diff --git a/hgext/histedit.py b/hgext/histedit.py
> > --- a/hgext/histedit.py
> > +++ b/hgext/histedit.py
> > @@ -169,11 +169,7 @@ the drop to be implicit for missing comm
> >
> >  """
> >
> > -try:
> > -    import cPickle as pickle
> > -    pickle.dump # import now
> > -except ImportError:
> > -    import pickle
> > +import pickle
>
> We generally use cPickle without fallback. I'll change it in flight to use
> cPickle.
>

I believe cPickle is problematic on PyPy somehow (buggy or not there),
so that's the wrong fix in this case.

> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel