[PATCH 1 of 3 V2] context: add a method to tell if a changeset is secret

[Pierre-Yves David]

On 12/27/2015 05:46 AM, Laurent Charignon wrote:
> # HG changeset patch
> # User Laurent Charignon <lcharignon at fb.com>
> # Date 1450897553 28800
> #      Wed Dec 23 11:05:53 2015 -0800
> # Node ID 1721c112f0194a078103b3b673de236b5cd5cd52
> # Parent  fe376159a58d9b3d748b669ac011b0eed0346fea
> context: add a method to tell if a changeset is secret
>
> Before this patch we had to compare the phase of a changeset to phases.secret
> to know if a changeset was secret. This patch gives us an easier way to do that
> and can make our code more legible.

I do not think this is going to be widely used enough to justify a new 
method on an already large god object.

Also, if we really wanted to move in that direction, we want a more 
generic property here to capture the actual thing we seems to care about 
here, "exchanged". We applied the very same logic in the method right 
above "mutable" instead of "not public".

(Also, I'm not convinced about this whole series, see (coming) reply to 
other changesets).

-- 
Pierre-Yves David