[PATCH 3 of 3 V2] commit: commit should ignore secret heads for "new heads" warning (issue5017)

[Pierre-Yves David]

On 12/29/2015 11:22 PM, Augie Fackler wrote:
> On Sat, Dec 26, 2015 at 08:46:35PM -0800, Laurent Charignon wrote:
>> # HG changeset patch
>> # User Laurent Charignon <lcharignon at fb.com>
>> # Date 1451191507 28800
>> #      Sat Dec 26 20:45:07 2015 -0800
>> # Node ID 50ddc2300ee6860203e80edbd88bf52fb5495c67
>> # Parent  edd65810df9b8ddb2c78727d2580b8faea6800a7
>> commit: commit should ignore secret heads for "new heads" warning (issue5017)
>
> Queued these, thanks!

>> The warning exists to keep people from having multi-headed push trouble
>> but since secret commits are not pushed we don't need to display this
>> warning.

I think the current behavior is good and should be kept. I've posted a 
more detailed explanation on the bug report.

https://bz.mercurial-scm.org/show_bug.cgi?id=5017

>> The logic is implemented at the top level (before displaying the warning
>> message) to avoid adding phase related code at lower level that is used in
>> multiple places and doesn't care about phases.

If we really want to got that way, I think the right criteria is not 
"secret" but "server" an easy way to enforce it is to do all computation 
for the "new-head-warning" with the "served" filter.

-- 
Pierre-Yves David