[hglib] Commit broken against hg default branch

Kevin Bullock kbullock+mercurial at ringworld.org
Thu Dec 31 21:53:10 UTC 2015


python-hglib tests are failing on commit --amend against default[1]. I've bisected it to:

changeset:   27452:a01d3d32b53a
user:        FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
date:        Wed Dec 02 03:12:07 2015 +0900
summary:     commands: make commit acquire locks before processing (issue4368)

Looks like the hooks now get run _after_ the commit ID is spit out, which breaks hglib's expectations at <https://selenic.com/repo/python-hglib/file/ffca01835a7c/hglib/client.py#l571>. Does anyone have thoughts on where the fix should go -- in python-hglib or in commands.commit()?

[1]: http://buildbot.mercurial-scm.org/builders/python-hglib/builds/1

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list