[PATCH 2 of 2] revset: have rev() validate input by repo.__contains__()

[Pierre-Yves David]

On 02/02/2015 10:07 PM, Matt Mackall wrote:
> On Mon, 2015-02-02 at 14:23 +0000, Pierre-Yves David wrote:
>>
>> On 02/02/2015 02:15 PM, Yuya Nishihara wrote:
>>> # HG changeset patch
>>> # User Yuya Nishihara <yuya at tcha.org>
>>> # Date 1420884012 -32400
>>> #      Sat Jan 10 19:00:12 2015 +0900
>>> # Node ID d247b985ebc0acdb837bc89288c8569151446620
>>> # Parent  184aa519a7a72ab10361d91f66455e3cea8f4f50
>>> revset: have rev() validate input by repo.__contains__()
>>>
>>> fullreposet.__contains__() will be rewritten in order to support "null"
>>> revision, so "rev()" can't rely on it.
>>
>> Note that this change broke some of the Mercurial extension (because
>> ::nullrev stopped being empty). So we have to be careful (even if this
>> change makes sense).
>
> Sometimes I think there might be two Pierre-Yves Davids out there.
> There's the one the who makes so many breaking internals changes that he
> often can't even keep Mercurial compatible with his own extension
> week-to-week.. and then there's some other guy who wrote the paragraph
> above.
>
> That other guy should probably see our documented policy before doing
> too many more reviews:
>
> http://mercurial.selenic.com/wiki/MercurialApi

My point is the message above was: the previous "nullrev" in revset 
related changes broke stuff (actually it broke stuff in core, releaved 
by evolve tests). So I expect more funny breakage from this change and 
we have to be "careful" about finding them (no idea how).

-- 
Pierre-Yves David (I'll let your decide which version of him)

-- 
Pierre-Yves David