[PATCH 3 of 4] histedit: switch state to store node instead of ctx

[Pierre-Yves David]

On 02/02/2015 11:55 PM, Mateusz Kwapich wrote:
> # HG changeset patch
> # User Mateusz Kwapich <mitrandir at fb.com>
> # Date 1422314748 28800
> #      Mon Jan 26 15:25:48 2015 -0800
> # Node ID 5868827d6d1a2a75d9628d502281d0d7fad2b115
> # Parent  0c8cf9835334d76f52e7cebf9d70b5b0df646871
> histedit: switch state to store node instead of ctx
>
> As part of making histedit more robust to odd changes between actions, we need
> to store the parentctxnode on the state instead of the parentctx. This will
> allow the parentctx to be deleted in the middle of a histedit (like if someone
> pauses the histedit and amends a file away).

why is it necessary to change it on the state object itself? It is not 
obvious to me how it helps.

(If you want to clean stuff in this area, feel free to also nuke the 
last on disk usage of pickle in the Mercurial codebase (beside convert 
madness).

-- 
Pierre-Yves David