[PATCH 1 of 2 STABLE] revset: get revision number of each nodes gotten from target namespaces

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Feb 3 09:53:45 CST 2015



On 02/03/2015 01:04 PM, FUJIWARA Katsunori wrote:
> # HG changeset patch
> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> # Date 1422968189 -32400
> #      Tue Feb 03 21:56:29 2015 +0900
> # Branch stable
> # Node ID 147878ac1d02298847d5b2a0d2e06063b2fefe91
> # Parent  3667bc21b8773715d9472a3b4e034b77e62c6451
> revset: get revision number of each nodes gotten from target namespaces
>
> Before this patch, revset predicate "named()" uses each nodes gotten
> from target namespaces directly.
>
> This causes problems below:
>
>    - combination of other predicates doesn't work correctly, because
>      they assume that revisions are listed up in number
>
>    - "hg log" doesn't show any revisions for "named()" result, because:
>
>      - "changeset_printer" stores formatted output for each revisions
>        into dict with revision number (= ctx.rev()) as a key of them
>
>      - "changeset_printer.flush(rev)" writes stored output for
>        the specified revision, but
>
>      - "commands.log" invokes it with the node, gotten from "named()"
>
>    - "hg debugrevspec" shows nodes (= may be binary) directly
>
> Difference between revset predicate "tag()" and "named('tags')" in
> tests is fixed in subsequent patch.

Surprise, the old changesets had no tests and ended up being an absolute 
non-sense. Queuing for stable.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list