[PATCH 1 of 6 faster-obsmarkers v2] obsolete: make optional offset parameter to fm*readmarkers required

Augie Fackler raf at durin42.com
Tue Feb 3 18:31:09 UTC 2015


# HG changeset patch
# User Augie Fackler <augie at google.com>
# Date 1421764702 18000
#      Tue Jan 20 09:38:22 2015 -0500
# Node ID 5e1e659995943100cfaf76135f8df2b43bfe05ce
# Parent  663686acc4153e7d26eb88dd5d675543df69abf4
obsolete: make optional offset parameter to fm*readmarkers required

It was always passed by the only callsite, so just make it required.

diff --git a/mercurial/obsolete.py b/mercurial/obsolete.py
--- a/mercurial/obsolete.py
+++ b/mercurial/obsolete.py
@@ -146,7 +146,7 @@ usingsha256 = 2
 _fm0fsize = _calcsize(_fm0fixed)
 _fm0fnodesize = _calcsize(_fm0node)
 
-def _fm0readmarkers(data, off=0):
+def _fm0readmarkers(data, off):
     # Loop on markers
     l = len(data)
     while off + _fm0fsize <= l:
@@ -285,7 +285,7 @@ def _fm0decodemeta(data):
 _fm1metapair = 'BB'
 _fm1metapairsize = _calcsize('BB')
 
-def _fm1readmarkers(data, off=0):
+def _fm1readmarkers(data, off):
     # make some global constants local for performance
     noneflag = _fm1parentnone
     sha2flag = usingsha256


More information about the Mercurial-devel mailing list