[PATCH 2 of 4 V2] histedit: switch state to store node instead of ctx

Mateusz Kwapich mitrandir at fb.com
Tue Feb 3 16:06:24 CST 2015


It’s just a first step in direction of not relying on parentctx during 
hist edit.
Until now if the parentctx was missing the histedit failed during loading 
the state. In this commit I’m moving the ctx resolution down the stack so 
I can then gradually remove the dependence on the ctx from all places 
where it’s used.




On 2/3/15, 3:17 AM, "Pierre-Yves David" <pierre-yves.david at ens-lyon.org> 
wrote:

>
>
>On 02/03/2015 12:32 AM, Mateusz Kwapich wrote:
>> # HG changeset patch
>> # User Mateusz Kwapich <mitrandir at fb.com>
>> # Date 1422314748 28800
>> #      Mon Jan 26 15:25:48 2015 -0800
>> # Node ID 5868827d6d1a2a75d9628d502281d0d7fad2b115
>> # Parent  0c8cf9835334d76f52e7cebf9d70b5b0df646871
>> histedit: switch state to store node instead of ctx
>
>(I commented on V1 before seing V2, copy pasting comment)
>
>why is it necessary to change it on the state object itself? It is not 
>obvious to me how it helps.
>
>(If you want to clean stuff in this area, feel free to also nuke the 
>last on disk usage of pickle in the Mercurial codebase (beside convert 
>madness).
>
>
>
>-- 
>Pierre-Yves David


More information about the Mercurial-devel mailing list