[PATCH 2 of 3] branchmap: backout 6bf93440a717

Matt Harbison mharbison72 at gmail.com
Tue Feb 3 21:49:39 CST 2015


# HG changeset patch
# User Matt Harbison <matt_harbison at yahoo.com>
# Date 1422726125 18000
#      Sat Jan 31 12:42:05 2015 -0500
# Node ID 8df3c46c0c076748e9d0e54e536fd2ac06e465ac
# Parent  f78eca3cb69711a33cf70b0a3f84f3fe8f730e43
branchmap: backout 6bf93440a717

This is no longer needed now that the vfs class handles seeking to EOF when it
opens a file in append mode.

diff --git a/mercurial/branchmap.py b/mercurial/branchmap.py
--- a/mercurial/branchmap.py
+++ b/mercurial/branchmap.py
@@ -407,9 +407,6 @@
             try:
                 if self._rbcnamescount != 0:
                     f = repo.vfs.open(_rbcnames, 'ab')
-                    # The position after open(x, 'a') is implementation defined-
-                    # see issue3543.  SEEK_END was added in 2.5
-                    f.seek(0, 2) #os.SEEK_END
                     if f.tell() == self._rbcsnameslen:
                         f.write('\0')
                     else:
@@ -434,9 +431,6 @@
             revs = min(len(repo.changelog), len(self._rbcrevs) // _rbcrecsize)
             try:
                 f = repo.vfs.open(_rbcrevs, 'ab')
-                # The position after open(x, 'a') is implementation defined-
-                # see issue3543.  SEEK_END was added in 2.5
-                f.seek(0, 2) #os.SEEK_END
                 if f.tell() != start:
                     repo.ui.debug("truncating %s to %s\n" % (_rbcrevs, start))
                     f.seek(start)


More information about the Mercurial-devel mailing list