[PATCH V2] revset: omit dropping tip from the result of tag() (BC)

Pierre-Yves David pierre-yves.david at ens-lyon.org
Wed Feb 4 16:00:05 CST 2015



On 02/04/2015 09:36 PM, Matt Mackall wrote:
> On Wed, 2015-02-04 at 16:04 -0500, Augie Fackler wrote:
>> On Wed, Feb 4, 2015 at 2:05 AM, FUJIWARA Katsunori
>> <foozy at lares.dti.ne.jp> wrote:
>>> # HG changeset patch
>>> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
>>> # Date 1423033325 -32400
>>> #      Wed Feb 04 16:02:05 2015 +0900
>>> # Node ID be0452c3be1b5f4bb9b425049a36f81238873fc2
>>> # Parent  e1dbe0b215ae137eec53ceb12440536d570a83d2
>>> revset: omit dropping tip from the result of tag() (BC)
>>
>> I don't know how mpm feels, but I feel like this is going the wrong
>> way. More things should omit tip, rather than show it.
>
> Yep, I'd go the other way and drop it from named(). 'tip' is definitely
> an idea we're trying to eliminate.

I probably mis-convoyed something in my previous review set. I agree 
with Augie and Matt here. Lets drop tip into oblivion for new API.


-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list