[PATCH 3 of 9 sethelp] error: add a new NotAFunction error type

Matt Mackall mpm at selenic.com
Thu Feb 5 16:49:41 CST 2015


On Thu, 2015-02-05 at 17:45 -0500, Augie Fackler wrote:
> On Feb 4, 2015, at 5:25 PM, Matt Mackall <mpm at selenic.com> wrote:
> 
> > On Wed, 2015-02-04 at 13:15 -0500, Augie Fackler wrote:
> >> # HG changeset patch
> >> # User Augie Fackler <augie at google.com>
> >> # Date 1422300661 18000
> >> #      Mon Jan 26 14:31:01 2015 -0500
> >> # Node ID 04c92caf02b761ce3e2f46618b6b93e09e2b1bd3
> >> # Parent  31f51746469a974042b75e32095e20b565bba8f4
> >> error: add a new NotAFunction error type
> > 
> > I like the idea of this series, but I think you may not be thinking big
> > enough. We've also got template keywords and such to complain about,
> > never mind command names. So I think we need a more generic
> > UnknownIdentifier exception and probably a more widely available utility
> > function to find the matches.
> 
> *nod* I viewed this mostly as a prelude to handling other things. At least command names came to mind.
> 
> Okay if I do a resend of this series with NotAFunction renamed to UnknownIdentifier or UnknownSymbol? Do you have a preference between those two?

I picked Identifier because we already have a subset of symbols known as
symbols. I'd take this with this and the difflib thing.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list