[PATCH resubmission-after-33-cycle] setup.py: attempt to use setuptools

[Gregory Szorc]

On Tue, Feb 10, 2015 at 7:50 AM, Augie Fackler <raf at durin42.com> wrote:

> On Fri, Feb 06, 2015 at 05:14:15PM -0600, Matt Mackall wrote:
> > On Fri, 2015-02-06 at 17:09 -0600, Matt Mackall wrote:
> > > On Thu, 2015-02-05 at 18:52 -0800, Gregory Szorc wrote:
> > > > # HG changeset patch
> > > > # User Gregory Szorc <gregory.szorc at gmail.com>
> > > > # Date 1421431223 28800
> > > > #      Fri Jan 16 10:00:23 2015 -0800
> > > > # Node ID 975f6586908de6526bf5165d09f8622437a682e5
> > > > # Parent  a9b61dbdb827165a9fd9d44dd42b892dbd9fa07c
> > > > setup.py: attempt to use setuptools
> > >
> > > Ok, queued, thanks. check-code says hi.
> >
> > Also, run-tests explodes with pages of build spew on both Centos and
> > Debian. Please investigate.
>
> I re-queued this, and have re-dropped it. I still get pages of spew on
> firefly. I didn't test anywhere else. Sample output:
>
> warning: Testing with unexpected mercurial lib:
> /tmp/hgtests.MZx6LB/install/lib/python/mercurial-3.3_114_65cb46ed0c43-py2.7-linux-x86_64.egg/mercurial
>          (expected /tmp/hgtests.MZx6LB/install/lib/python/mercurial)
> .
> --- /home/augie/hg/tests/test-convert-svn-encoding.t
> +++ /home/augie/hg/tests/test-convert-svn-encoding.t.err
> @@ -11,135 +11,11 @@
>  Convert while testing all possible outputs
>
>    $ hg --debug convert svn-repo A-hg
> +  /bin/sh: 1:
> /tmp/hgtests.MZx6LB/install/lib/python/mercurial-3.3_114_65cb46ed0c43-py2.7-linux-x86_64.egg/EGG-INFO/scripts/hg:
> Permission denied
>    initializing destination A-hg repository
>
>
> Note that this was after a patch I made to set zip_safe=False when
> using setuptools. I think that got us closer, but it looks like the hg
> stub script is broken using setuptools. Yay.
>
> (I'm done investigating this for now, and leave it to Greg.)


Gah. More failures due to my test environment not having all the optional
features installed.

But, yeah, this smells like something we were lucky to catch in tests at
all. I may need to write some explicit test coverage for packaging output.
I'll keep attacking this.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20150210/d6ef7056/attachment.html>