[PATCH resubmission-after-33-cycle] setup.py: attempt to use setuptools

Gregory Szorc gregory.szorc at gmail.com
Sat Feb 21 11:29:59 CST 2015


On Fri, Feb 20, 2015 at 8:37 AM, Pierre-Yves David <
pierre-yves.david at ens-lyon.org> wrote:

>
>
> On 02/10/2015 03:50 PM, Augie Fackler wrote:
>
>> On Fri, Feb 06, 2015 at 05:14:15PM -0600, Matt Mackall wrote:
>>
>>> On Fri, 2015-02-06 at 17:09 -0600, Matt Mackall wrote:
>>>
>>>> On Thu, 2015-02-05 at 18:52 -0800, Gregory Szorc wrote:
>>>>
>>>>> # HG changeset patch
>>>>> # User Gregory Szorc <gregory.szorc at gmail.com>
>>>>> # Date 1421431223 28800
>>>>> #      Fri Jan 16 10:00:23 2015 -0800
>>>>> # Node ID 975f6586908de6526bf5165d09f8622437a682e5
>>>>> # Parent  a9b61dbdb827165a9fd9d44dd42b892dbd9fa07c
>>>>> setup.py: attempt to use setuptools
>>>>>
>>>>
>>>> Ok, queued, thanks. check-code says hi.
>>>>
>>>
>>> Also, run-tests explodes with pages of build spew on both Centos and
>>> Debian. Please investigate.
>>>
>>
>> I re-queued this, and have re-dropped it. I still get pages of spew on
>> firefly. I didn't test anywhere else. Sample output:
>>
>> warning: Testing with unexpected mercurial lib:
>> /tmp/hgtests.MZx6LB/install/lib/python/mercurial-3.3_114_
>> 65cb46ed0c43-py2.7-linux-x86_64.egg/mercurial
>>           (expected /tmp/hgtests.MZx6LB/install/lib/python/mercurial)
>>
>
>
> This patch is apparently moving the install from good old python package
> to eggs.
>
> Eggs are very (very) evil and we should -not- switch to them. I've a
> strong -1 for this patch
>
> (I know it is already dropped, but for less clear reason)


FTR, I initially wrote this patch because
https://python-packaging-user-guide.readthedocs.org/en/latest/distributing.html
recommends setuptools and I figured we'd need setuptools to take advantage
of some modern packaging foo, namely wheels. Only when investigating the
test failure fallout did I realize setuptools was quietly turning things
into egg-like installs. At that point I screamed and pulled the ejection
handle. So we are in deep agreement over not adopting setuptools.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20150221/5243d779/attachment.html>


More information about the Mercurial-devel mailing list