[PATCH 3 of 3] tags: preserve filtered .hgtags filenodes in tags cache (issue4550)

Ryan McElroy rm at fb.com
Wed Feb 25 15:25:40 CST 2015


On 2/25/2015 1:08 PM, Gregory Szorc wrote:
>
>         + allheads = ourheads | unfilteredheads
>
>     /me confused: Why isn't unfilteredheads == allheads?
>
>
> There are two flavors of DAG heads: unfiltered and filtered. If a true 
> DAG head is hidden, you'll need to record its parent, as it appears as 
> a head on filtered repos.
>
> This is a case not explicitly tested by this patch series. This code 
> may even cause some heads to get dropped from the cache. However, that 
> scenario should be rare and will only result in loss of a handful of 
> heads, not the potentially hundreds that will be lost if all hidden 
> DAG heads need recomputed.

Ah, yes, that makes sense. Thanks for the clarification.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20150225/d3cde801/attachment.html>


More information about the Mercurial-devel mailing list