[PATCH 1 of 4] templatekw: add troubles state

[Pierre-Yves David]

On 01/09/2015 06:36 AM, Romain DEP. wrote:
> Le 09/01/2015 05:46, Pierre-Yves David a écrit :
>> On 01/06/2015 01:48 AM, Romain DEP. wrote:
>>> # HG changeset patch
>>> # User Romain DEP. <rom1dep at gmail.com>
>>> # Date 1420456028 -3600
>>> #      Mon Jan 05 12:07:08 2015 +0100
>>> # Node ID e42d7e651a8f68ff55cea9f67f8247ebe82a6142
>>> # Parent  090d3c5b76939f9b224324ede795397bbd2a3b58
>>> templatekw: add troubles state
>>
>> From what I get, the template keyword is not translated. This makes
>> sense if it aimed at producing label, but it would also be very useful
>> for real output.
> This is indeed aimed at producing labels and is purposely not translated
> (neither is showphase for instance)

Should we also have one for textual purpose? how would this cohabit with 
the one or label purpose?

>> Moreover, for labeling purpose, I think that introducing a 'troubled'
>> flag first would be more valuable.
> I think that it should either output "troubled"/"untroubled" or list the
> different kind of troubles encountered, this was discussed briefly on
> IRC, and I think that being specific here is a good thing.

As someone who already implemented styling for troubled changesets in 
hgview, tortoisehg and smartlog, I think have a 'troubled' binary flag 
is a better solution as a start. What can I do to convinces you so ?


-- 
Pierre-Yves David