[PATCH 1 of 4 lazy-manifest] manifest.c: new extension code to lazily parse manifests

Sean Farley sean.michael.farley at gmail.com
Fri Jan 9 16:14:09 CST 2015


Augie Fackler writes:

> On Jan 8, 2015 6:50 PM, "David Champion" <dgc at uchicago.edu> wrote:
>>
>> * On 08 Jan 2015, Matt Mackall wrote:
>> >
>> > > +/* yay c89 */
>> > > +#define true 1
>> > > +#define false 0
>> > > +typedef unsigned char bool;
>> >
>> > If we must have this, it probably belongs in util.h.
>>
>> Is <stdbool.h> an option?
>
> It looks like that'll be missing on VC9, which I think is what's in use on
> windows for python extensions.

Yep, it's missing from VC9. I've cleaned up the C89-isms and pushed:

hg pull smf.io/hg -r lazy-manifest

It more than likely will need another pass to consolidate lines and
whatnot but now it compiles on windows with VC9 (and VC12 for those of
us that compiled python from source).

I'll follow up with some notes on other patches as well.



More information about the Mercurial-devel mailing list