[PATCH 3 of 3 v4] revset: use localrepo revbranchcache for branch name filtering

[Augie Fackler]

On Sat, Jan 10, 2015 at 12:16:27PM -0500, Matt Harbison wrote:
> On Sat, 10 Jan 2015 07:42:25 -0500, Mads Kiilerich <mads at kiilerich.com>
> wrote:
>
> >On 01/10/2015 09:19 AM, Adrian Buehlmann wrote:
> >>On 2015-01-10 04:26, Matt Harbison wrote:
> >>>On Fri, 09 Jan 2015 11:04:00 -0500, Mads Kiilerich <mads at kiilerich.com>
> >>>wrote:
> >>>
> >>>># HG changeset patch
> >>>># User Mads Kiilerich <madski at unity3d.com>
> >>>># Date 1420671663 -3600
> >>>>#      Thu Jan 08 00:01:03 2015 +0100
> >>>># Node ID 596acd20068b01d7f2ad2d6f6cd8f5963183ce80
> >>>># Parent  1885dd81dd140a9c56b94dd3af811cc040d07a54
> >>>>revset: use localrepo revbranchcache for branch name filtering
> >>>I get this failure on Windows:
> >>I'm currently not motivated to have a deep look myself, but this reminds
> >>me of http://selenic.com/repo/hg/rev/48c232873a54
> >>
> >>(pattern of calling tell() right after open())
> >>
> >>I at least would suggest to check this.
> >
> >
> >Thanks - that seems like the problem. Matt, can you confirm that adding a
> >seek to end solves the problem?
> >
> >/Mads
>
> Thanks, that did the trick.  I submitted a patch for it.
>
> Maybe vfs.open() should automatically seek to the end if opened in append
> mode?  This seems like a fairly easy to miss implementation detail,
> especially since Linux apparently does what everyone assumes is the correct
> thing.

Agreed. I'd love to see a patch for that, but probably at the start of
the next cycle rather than now.

> Not sure if it is a good idea this close to the code freeze though.
>
> --Matt
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel