[PATCH 1 of 4 lazy-manifest v2] manifest.c: new extension code to lazily parse manifests

[Augie Fackler]

On Jan 13, 2015, at 9:22 PM, Martin von Zweigbergk <martinvonz at google.com> wrote:

> 
> 
> On Tue, Jan 13, 2015, 18:11 Augie Fackler <raf at durin42.com> wrote:
> 
> 
> On Jan 13, 2015, at 7:42 PM, Martin von Zweigbergk <martinvonz at google.com> wrote:
> 
> > As I reported on IRC, the 'setitem' method seems slow. On the Mozilla repo, running
> >
> >   hg co -C 1813b && hg mv -q intl i18n && time hg ci -qm 'move intl'
> >
> > takes 6.3s with current hg and 1m21s with these patches applied. It may very be related to your TODO in setitem.
> 
> Yeah, I think this is the point where we should drop v2, and I’ll work on a bulk-add function (shouldn’t take long) to mitigate that problem.
> 
> 
> 
> I think I once suggested making it transparent to the user by instead storing modifications separately and then compacting them on any query operation. That should effectively be the same (performance-wise) as an explicit bulk update operation, but without the need to update any callers.

But if someone inserts a new entry, then does it again, the binary search won’t work, which makes things frustrating. If you’ve got an idea for that, I’d love to hear it though (I haven’t come up with anything better.)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20150113/6b934283/attachment.pgp>