[PATCH 2 of 4] hgweb: close <p> elements

Anton Shestakov engored at ya.ru
Wed Jan 14 03:11:10 CST 2015


13.01.2015, 01:15, "Mads Kiilerich" <mads at kiilerich.com>:
> On 01/10/2015 02:41 PM, Anton Shestakov wrote:
>>  # HG changeset patch
>>  # User Anton Shestakov <engored at ya.ru>
>>  # Date 1420883522 -28800
>>  #      Sat Jan 10 17:52:02 2015 +0800
>>  # Node ID 27d20a4ed2e6d570b99a1f0b4a688fcb02e2659e
>>  # Parent  febf58cfae9ec7f8a29ab785d145169998008d55
>>  hgweb: close <p> elements
>>
>>  <p> elements can only contain inline elements, so as soon as browser encounters
>>  a block element (e.g. block <div>) "inside" a <p>, it puts an implicit </p>.
>>  It's better to do this explicitly.
>
> This is obviously fixing a bug. But leaving an empty p also seems weird.
> It is very un-semantic markup.
>
> Would it break the rendering if it was removed? If so, shouldn't that be
> addressed in CSS instead?

Apparently all those <p> did was add some padding, so yes, that will go to css.
I'll get to that in my next series, since this is already queued.


More information about the Mercurial-devel mailing list