[PATCH 1 of 6 RFC] localrepo: remove all internal uses of localrepo.opener

Matt Mackall mpm at selenic.com
Wed Jan 14 16:28:52 CST 2015


On Sun, 2015-01-11 at 09:59 +0100, Angel Ezquerra wrote:
> On Sun, Jan 11, 2015 at 7:12 AM, Pierre-Yves David
> <pierre-yves.david at ens-lyon.org> wrote:
> >
> >
> > On 01/10/2015 06:58 PM, Matt Harbison wrote:
> >>
> >> On Sat, 10 Jan 2015 20:20:50 -0500, Angel Ezquerra
> >> <angel.ezquerra at gmail.com> wrote:
> >>
> >>> # HG changeset patch
> >>> # User Angel Ezquerra <angel.ezquerra at gmail.com>
> >>> # Date 1420927372 -3600
> >>> #      Sat Jan 10 23:02:52 2015 +0100
> >>> # Node ID 459444107fc272ee7ca15cc9ac72602d60ed364f
> >>> # Parent  678f53865c6860a950392691814766957ee89316
> >>> localrepo: remove all internal uses of localrepo.opener
> >>
> >>
> >> The series LGTM.  The test suite on my Linux VM is happy with all 6
> >> applied, with the following skips:
> >
> >
> > I'm not super eager to drop the opener version yet as this would break
> > unsuspicious extension. I would go with a (new-feature) developper warning
> > for a few version.
> >
> > --
> > Pierre-Yves David
> 
> OK. Do we have a standard way of doing that?

Yep: mark the patch that removes the feature with (API) and then chuckle
quietly to yourself.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list