[PATCH 5 of 5] log: use namespace logname and colorname

Ryan McElroy rm at fb.com
Thu Jan 15 15:48:08 CST 2015


On 1/14/2015 10:58 PM, Sean Farley wrote:
> # HG changeset patch
> # User Sean Farley <sean.michael.farley at gmail.com>
> # Date 1421296187 28800
> #      Wed Jan 14 20:29:47 2015 -0800
> # Node ID dc1f57f272ce8f2662261368cbe0ce24a12b4463
> # Parent  3f25179d696ba392ade8b1c83024e14bcb1dd534
> log: use namespace logname and colorname
>
> Now that we have the machinary to change the log name and the color label used,
> let's use that. Tests have been updated accordingly.
This series looks good to me. The suggestions I had (around enforcing 
that required parameters are not None) can be implemented later since 
they don't change behavior, only the safety of implementing future 
namespace users. I'd suggest getting this in before the cutoff and 
worrying about my suggestion later if at all.


More information about the Mercurial-devel mailing list