[PATCH 2 of 4] add: pass options via keyword args

Matt Harbison mharbison72 at gmail.com
Thu Jan 15 22:20:25 CST 2015


On Thu, 15 Jan 2015 23:00:58 -0500, Mads Kiilerich <mads at kiilerich.com>  
wrote:

> On 01/16/2015 04:39 AM, Matt Harbison wrote:
>> # HG changeset patch
>> # User Matt Harbison <matt_harbison at yahoo.com>
>> # Date 1421114357 18000
>> #      Mon Jan 12 20:59:17 2015 -0500
>> # Node ID c9313d348ff8b373820e49359b03950875e737dc
>> # Parent  6c893ee9c85def62e2f19de9f4a2b5288a12a5fd
>> add: pass options via keyword args
>>
>> The largefiles extensions needs to be able to pass --large, --normal and
>> --lfsize to subrepos via cmdutil.add() and hgsubrepo.add().  Rather  
>> than add
>> additional special purpose arguments, stop extracting the existing args  
>> from the
>> **opts passed to commands.add() and just pass them along.
>
> I guess this patch should come before patch 1 to make sure every  
> revision in history works?

Not sure I understand.  The test suite (at least '*large*', just now) runs  
clean with only #1 applied, and also 1 + 2.  There's no behavior change  
until #3, when the subrepo can call back into largefiles code via the  
cmdutil override.

But if you think they are better reordered, I have no issue with someone  
doing that in flight.

--Matt


More information about the Mercurial-devel mailing list