[PATCH 1 of 2] changegroup.writebundle: provide ui

Pierre-Yves David pierre-yves.david at ens-lyon.org
Fri Jan 16 17:30:07 CST 2015



On 01/16/2015 03:10 PM, Eric Sumner wrote:
> --- a/mercurial/changegroup.py
> +++ b/mercurial/changegroup.py
> @@ -79,7 +79,7 @@
>   # hgweb uses this list to communicate its preferred type
>   bundlepriority = ['HG10GZ', 'HG10BZ', 'HG10UN']
>
> -def writebundle(cg, filename, bundletype, vfs=None):
> +def writebundle(cg, filename, bundletype, vfs=None, ui=None):
>       """Write a bundle file and return its filename.
>
>       Existing files will not be overwritten.
> @@ -88,6 +88,8 @@
>       The bundle file will be deleted in case of errors.
>       """
>
> +    if ui is None:
> +        raise ValueError(_('ui parameter is required'))

This part is strange. After discussion with eric in real life. he will 
more ui as the first parameter and make it required.


-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list