[PATCH 2 of 5 stable cpychecker] dirs: fix leak of iterator in dirs_fromiter
Augie Fackler
raf at durin42.com
Tue Jan 27 09:26:33 CST 2015
# HG changeset patch
# User Augie Fackler <augie at google.com>
# Date 1422371404 18000
# Tue Jan 27 10:10:04 2015 -0500
# Branch stable
# Node ID 190d25e48de681423dac253939139a970e46cfc1
# Parent 25af70176080cd54761b1624c900dc19252c9994
dirs: fix leak of iterator in dirs_fromiter
Spotted with cpychecker.
diff --git a/mercurial/dirs.c b/mercurial/dirs.c
--- a/mercurial/dirs.c
+++ b/mercurial/dirs.c
@@ -175,6 +175,7 @@ static int dirs_fromiter(PyObject *dirs,
}
ret = PyErr_Occurred() ? -1 : 0;
+ Py_DECREF(iter);
Py_XDECREF(item);
return ret;
}
More information about the Mercurial-devel
mailing list