[PATCH 1 of 2] bookmark: remove the "touch changelog" hack

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Jul 7 20:35:41 CDT 2015


# HG changeset patch
# User Pierre-Yves David <pierre-yves.david at fb.com>
# Date 1435738197 25200
#      Wed Jul 01 01:09:57 2015 -0700
# Node ID a59f61d46778910f1ee25adf6f64667d443285b0
# Parent  3948cb4d0ae70e7257e47e2fd9f657c0c1af7c2b
bookmark: remove the "touch changelog" hack

Any changes to bookmark used to touch the changelog to ensure hgweb were
reloaded. This was fairly hacky and stop working when bookmark are moved as
part of the transaction. As hgweb is now explicitly tracking bookmarks change,
we can remove this hack (and no test break).

diff --git a/mercurial/bookmarks.py b/mercurial/bookmarks.py
--- a/mercurial/bookmarks.py
+++ b/mercurial/bookmarks.py
@@ -92,16 +92,10 @@ class bmstore(dict):
 
             file = repo.vfs('bookmarks', 'w', atomictemp=True)
             self._write(file)
             file.close()
 
-            # touch 00changelog.i so hgweb reloads bookmarks (no lock needed)
-            try:
-                repo.svfs.utime('00changelog.i', None)
-            except OSError:
-                pass
-
         finally:
             wlock.release()
 
     def _write(self, fp):
         for name, node in self.iteritems():


More information about the Mercurial-devel mailing list