[PATCH] convert: allow customizing git remote prefix

[Durham Goode]

On 7/14/15, 10:20 AM, "Sean Farley" <sean at farley.io> wrote:

>
>Pierre-Yves David <pierre-yves.david at ens-lyon.org> writes:
>
>> On 07/14/2015 06:07 AM, Durham Goode wrote:
>>> # HG changeset patch
>>> # User Durham Goode <durham at fb.com>
>>> # Date 1436848666 25200
>>> #      Mon Jul 13 21:37:46 2015 -0700
>>> # Node ID b2ff10e2fc12fe839781cb7ccd1d8d0302dd33f5
>>> # Parent  35fa7c77c754aa4d156c42abfdb61ca178468872
>>> convert: allow customizing git remote prefix
>>>
>>> Previously all git remotes were created as "remote/foo". This patch
>>>adds a
>>> configuration option for deciding what the prefix should be. This is
>>>useful if
>>> you want the bookmarks to be "origin/foo" like they are in git, or if
>>>you're
>>> integrating with the remotenames extension and don't want the local
>>>remote/foo
>>> bookmarks to overlap with the remote foo bookmarks.
>>
>> Random question: What would it take make convert extensible so that
>> remotename could take over the convertion of these label?
>
>Perhaps we should move some logic of remote bookmarks into core first,
>so that 'convert' would have a smoother transition?

We could refactor the bookmark creation logic in convert to be a separate
function and remotenames could wrap it.  But I don't think it matters
enough to actually do that work any time soon.