[PATCH 5 of 5 V2] changegroup: compute seen files as changesets are added (issue4750)

[Pierre-Yves David]

On 07/17/2015 11:25 PM, Matt Mackall wrote:
> On Wed, 2015-07-15 at 15:32 -0700, Gregory Szorc wrote:
>> # HG changeset patch
>> # User Gregory Szorc <gregory.szorc at gmail.com>
>> # Date 1436998444 25200
>> #      Wed Jul 15 15:14:04 2015 -0700
>> # Node ID e588eefb8ae309b18d4a2e4e28134d363fd9cf8e
>> # Parent  ed5d4ffdff877bfe632376a17a5a50cece817209
>> changegroup: compute seen files as changesets are added (issue4750)
>
> This all strikes me as too complex. I think we should deal with your
> primary problem (the pause) for 3.5 with a straightforward patch like
> the below, and then come back to the plumbing issues with flush and
> extra reads and such post-3.5. It doesn't seem like the performance
> impact of the additional flush is significant?
>
> (It's also worth noting that we could be fully-populating the branch
> cache here.)

And phases.

-- 
Pierre-Yves David