[PATCH 2 of 3 side-word (+4)] sshpeer: use a 'bufferedinputpipe' for standard output of the ssh process

Augie Fackler raf at durin42.com
Mon Jun 1 18:57:08 CDT 2015

On Mon, Jun 01, 2015 at 09:12:31AM -0700, Pierre-Yves David wrote:
> On 06/01/2015 08:16 AM, Yuya Nishihara wrote:
> >On Mon, 1 Jun 2015 08:01:55 +0900, Yuya Nishihara wrote:
> >This will slightly complicate doublepipe, so I'm not sure which is better.
> The original version was doing all in one. However, the buffer version using
> the 'os' module is isolated into the 'util' module (we avoid any 'os' usage
> in any top module) and the douple pipe which enforce the ssh specific logic
> of "forward stderr as 'remote:' output" live in the ssh specific 'sshpeer'
> module.
> Do you want me to update the commit message?

I think that might help future code archaeologists, so let's go for yes?

At this point we've got enough going on I'm having trouble keeping up
with all the churn at the protocol-ish layers, so I'm sure in two
years we'll be grateful for overly-verbose commit messages.

> (note: at some point we will replace all this with thread).

Would we be better off to just code that up now? It might be
significantly simpler...

> --
> Pierre-Yves David
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel

More information about the Mercurial-devel mailing list