[PATCH 3 of 3 V3] localrepo: better error message when revlog error and file addition (issue4675)

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Jun 2 15:05:36 CDT 2015



On 06/02/2015 12:13 PM, Jordi Gutiérrez Hermoso wrote:
> On Tue, 2015-06-02 at 12:08 -0700, Pierre-Yves David wrote:
>>
>> On 06/02/2015 12:07 PM, Jordi Gutiérrez Hermoso wrote:
>>> # HG changeset patch
>>> # User Jordi Gutiérrez Hermoso <jordigh at octave.org>
>>> # Date 1432239912 14400
>>> #      Thu May 21 16:25:12 2015 -0400
>>> # Node ID 6299517509f9a8912ff83fffa46cecf964ba779c
>>> # Parent  3353bc00fbb14f2930cf0e9b72be312e578d2f6e
>>> localrepo: better error message when revlog error and file addition (issue4675)
>>>
>>> At this level we have enough context for saying which filename caused
>>> the revlog error, and we can also add the hint from the revlog
>>> exception, if any.
>>
>> Do you think we should get a test for this? (down side would be to
>> create a 3Go file during test :-/)
>
> Right, I was thinking about that. Too many gigaoctets.
>
> An alternative could be to monkeypatch so that revlog._maxentrysize is
> a lot smaller for the duration of the test?

Sounds like a plan !


-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list