[PATCH 1 of 3 V3] revlog: raise an exception earlier if an entry is too large (issue4675)

[Matt Mackall]

On Wed, 2015-06-03 at 17:10 -0400, Jordi Gutiérrez Hermoso wrote:
> On Wed, 2015-06-03 at 15:11 -0500, Matt Mackall wrote:
> > On Tue, 2015-06-02 at 15:07 -0400, Jordi Gutiérrez Hermoso wrote:
> > > # HG changeset patch
> > > # User Jordi Gutiérrez Hermoso <jordigh at octave.org>
> > > # Date 1433271879 14400
> > > #      Tue Jun 02 15:04:39 2015 -0400
> > > # Node ID b7f66f13bd44581a107f2cb8f5655ea05aa06245
> > > # Parent  eb52de500d2a308761b65bc9efaf85272c27eca5
> > > revlog: raise an exception earlier if an entry is too large (issue4675)
> > 
> > Queued, but tweaked in flight to explicitly reference "2GiB" in the
> > error message rather than an arcane 9-digit number.
> 
> My concern with that is that unless you are computing "2GiB" from
> _maxentrysize, this adds a maintenance burden for the future should
> this variable ever change.

It's been 2G for 10 years, if we try to change it, this message will be
the least of our problems.

-- 
Mathematics is the supreme nostalgia of our time.