[PATCH 1 of 2 STABLE] context: don't complain about a matcher's subrepo paths in changectx.walk()

Matt Mackall mpm at selenic.com
Thu Jun 4 12:08:18 CDT 2015


On Wed, 2015-06-03 at 20:52 -0400, Matt Harbison wrote:
> Gentle ping on this.  I didn't want to just swipe the idea and run with it.

Go for it.

> Any reason not to make it a function on matchmod that internally calls
> copy() and then overwrites bad?  I'm thinking avoiding long undetected and
> subtle bugs if someone adds a field to the base class, but forgets to copy
> it here.  I have no idea what a copy() costs though.

Shortly after I proposed this, Drew added some new member variables to
match, so I may be coming around to your point of view.

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial-devel mailing list