[PATCH] hgweb: return 501 instead of 400 on unknown command

Matt Mackall mpm at selenic.com
Thu Jun 4 15:25:39 CDT 2015


On Thu, 2015-06-04 at 15:15 -0500, Martin von Zweigbergk wrote:
> # HG changeset patch
> # User Martin von Zweigbergk <martinvonz at google.com>
> # Date 1433439984 25200
> #      Thu Jun 04 10:46:24 2015 -0700
> # Node ID af314daf5f45ebbaa78d370bfc7982767f5fe5ee
> # Parent  c0995cd8ff6fdc44ff20835e005771f08452a353
> hgweb: return 501 instead of 400 on unknown command
> 
> When an unrecognized command is received, we return a 400 (Bad
> Request), which means that the client is to blame. Since the set of
> valid commands is not fixed, and it may just be a newer client sending
> a new command, it is more fair use 501 (Not Implemented).

But it's also an error for a client to ever send a command that it
hasn't discovered via capabilities. So the client is indeed to blame?

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial-devel mailing list