[PATCH 2 of 2] hgewb: disable progress when serving (issue4582)

[Pierre-Yves David]

On 06/08/2015 10:26 AM, Augie Fackler wrote:
> On Mon, Jun 8, 2015 at 1:24 PM, Pierre-Yves David
> <pierre-yves.david at ens-lyon.org> wrote:
>>
>>
>> On 06/08/2015 07:38 AM, Augie Fackler wrote:
>>>
>>> On Sun, Jun 07, 2015 at 08:08:07PM -0700, Pierre-Yves David wrote:
>>>>
>>>> # HG changeset patch
>>>> # User Pierre-Yves David <pierre-yves.david at fb.com>
>>>> # Date 1433722457 25200
>>>> #      Sun Jun 07 17:14:17 2015 -0700
>>>> # Node ID 1b7e8e1e3b91b073b670bf3dba9013e9b8cd9a95
>>>> # Parent  567035f46c6e91ef9420739bb7f21b7e3b9a6d10
>>>> hgewb: disable progress when serving (issue4582)
>>>
>>>
>>> How did you verify this fix? When I was trying very very similar
>>> things, I was unable to convince myself I'd fixed the bug because I
>>> couldn't reproduce the bug.
>>
>>
>> 1) Fired `hg serve`, cloned from it → progress bar (in the serve terminal)
>>
>> 2) Fired `hg serve` with the patch, cloned from it → no progress bar (in the
>> serve terminal)
>>
>> 3) profit.
>
> Would it work to say --config progress.assumetty=yes in a test so we
> could prove this works in a test?

Testing this in a tests is fairly complicated, because all our http test 
are run daemonised with the output sent who knows where.

I poked at it and gave up, willing to move forward on the topic.

-- 
Pierre-Yves David