[PATCH 1 of 2] tests: restore 'python' and '$TESTDIR/' for dummyssh invocation

Matt Mackall mpm at selenic.com
Wed Jun 10 11:29:05 CDT 2015


On Wed, 2015-06-10 at 00:00 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison <matt_harbison at yahoo.com>
> # Date 1433900373 14400
> #      Tue Jun 09 21:39:33 2015 -0400
> # Node ID abc40dc68229deb86ecc10ca6cb858211ee6cde3
> # Parent  ad14fb602e5e54e5432fbc776dd5d1bad63f1f68
> tests: restore 'python' and '$TESTDIR/' for dummyssh invocation
> 
> This is a backout of 46727fea7a00, and a partial backout of c3ecbf694904.
> 
> Windows won't execute 'dummyssh' directly, presumably because CreateProcess()
> doesn't know how to execute a bash script:
> 
>    $ hg clone -e "dummyssh" ssh://user@dummy/cloned sshclone
>    remote: 'dummyssh' is not recognized as an internal or external command,
>    remote: operable program or batch file.
>    abort: no suitable response from remote hg!
>    [255]

Ok, thanks. I was taking the existence of working bare shell and python
scripts elsewhere in the suite as evidence that they could be executed
directly. But it seems the story for calls from within Mercurial are
different (since they're not being evaluated by sh and thus don't know
about things like shebangs and pseudo-exec-bits).

Perhaps we can make this better for Cygwin/MinGW. If, for instance, we
have $SHELL in the environment, we can try to invoke commands via the
shell.

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial-devel mailing list