[PATCH 7 of 7] tests: simplify printenv calls

[Matt Harbison]

On Wed, 10 Jun 2015 10:28:54 -0400, Augie Fackler <raf at durin42.com> wrote:

> On Tue, Jun 09, 2015 at 08:22:26PM -0400, Matt Harbison wrote:
>> On Mon, 08 Jun 2015 22:14:39 -0400, Pierre-Yves David
>> <pierre-yves.david at ens-lyon.org> wrote:
>>
>> >
>> >
>> >On 06/08/2015 03:52 PM, Matt Mackall wrote:
>> >># HG changeset patch
>> >># User Matt Mackall <mpm at selenic.com>
>> >># Date 1433794215 18000
>> >>#      Mon Jun 08 15:10:15 2015 -0500
>> >># Node ID 642894d52913f5f67175adc342f550791cd84fa9
>> >># Parent  ee25f3b990c12896b136db9f96347f570302dbec
>> >>tests: simplify printenv calls
>> >>
>> >>Make printenv executable so that we don't need python, TESTDIR, or
>> >>quoting.
>> >
>> >check-code?
>> >
>> >This series is pushed to the clowncopter. Much appreciated  
>> improvements,
>> >thanks.
>> >
>> >I've not sure how windows feel about all this drop of "python", but I
>> >assume it will be fine. ccing some windows people to be sure.
>> >
>>
>> Windows doesn't like patch 5 (landed as 46727fea7a00).  For example:
>>
>> --- c:/Users/Matt/Projects/hg/tests/test-ssh-bundle1.t
>> +++ c:/Users/Matt/Projects/hg/tests/test-ssh-bundle1.t.err
>> @@ -43,470 +43,26 @@
>>  repo not found error
>>
>>    $ hg clone -e dummyssh ssh://user@dummy/nonexistent local
>> -  remote: abort: there is no Mercurial repository here (.hg not found)!
>> +  remote: 'dummyssh' is not recognized as an internal or external  
>> command,
>> +  remote: operable program or batch file.
>
> Hmm. I don't know windows *at all*, but this kind of looks like
> dummyssh isn't on PATH - does that match your diagnosis?

That was my first thought, even after it was mentioned on the ML that it  
_is_ on $PATH, and after I printed it out in a test and saw it was there.

But I think it is due to CreateProcess() [1].  I don't believe that will  
execute *.bat, *.vbs, etc either- that needs ShellExecute().  Note the  
contortions CreateProcess goes through to figure out what exe you are  
actually trying to launch with 'lpApplicationName'.

[1]  
https://msdn.microsoft.com/en-us/library/windows/desktop/ms682425%28v=vs.85%29.aspx