[PATCH V2] ui: flush stderr after printing a non-chained exception for Windows

Matt Mackall mpm at selenic.com
Mon Jun 15 12:39:49 CDT 2015


On Sun, 2015-06-14 at 17:50 +0900, Yuya Nishihara wrote:
> On Sat, 13 Jun 2015 12:46:20 -0400, Matt Harbison wrote:
> > # HG changeset patch
> > # User Matt Harbison <matt_harbison at yahoo.com>
> > # Date 1434161381 14400
> > #      Fri Jun 12 22:09:41 2015 -0400
> > # Node ID a82599a17c15532049827be88e52af31c7f8b3b3
> > # Parent  e8075329c5fbb651508777c15cb6bc9ae33b5dff
> > ui: flush stderr after printing a non-chained exception for Windows
> 
> > -                self.flush()  # flush debug or status message
> > -                traceback.print_exception(exc[0], exc[1], exc[2],
> > -                                          file=self.ferr)
> > +                output = traceback.format_exception(exc[0], exc[1], exc[2])
> > +                self.write_err(''.join(output))
> 
> This looks good to me, thanks.

Oops, queued this version instead.

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial-devel mailing list