[PATCH 2 of 2] bookmarks: drop filterredrevs cache invalidation no longer needed

Laurent Charignon lcharignon at fb.com
Tue Jun 16 12:03:24 CDT 2015


# HG changeset patch
# User Laurent Charignon <lcharignon at fb.com>
# Date 1434410169 25200
#      Mon Jun 15 16:16:09 2015 -0700
# Node ID 9a6db5a1f85dcd131715595acfec997bfbb7d145
# Parent  ec65a79467e52a695700f7abfa9e4c55f3cc6c91
bookmarks: drop filterredrevs cache invalidation no longer needed

In the previous patch we invalidate the cache of visible revisions when the
dynamic blockers when they are requested and the dynamic blockers have changed.

This allows us to centralize the cache invalidation logic for that case and
removes the need to invalidate the cache when an actual dynamic blocker occur.

We were invalidating the cache for bookmarks and since it is no longer needed,
we remove the cache invalidation.

diff --git a/mercurial/bookmarks.py b/mercurial/bookmarks.py
--- a/mercurial/bookmarks.py
+++ b/mercurial/bookmarks.py
@@ -80,7 +80,6 @@ class bmstore(dict):
         '''
         repo = self._repo
         self._writerepo(repo)
-        repo.invalidatevolatilesets()
 
     def _writerepo(self, repo):
         """Factored out for extensibility"""


More information about the Mercurial-devel mailing list