[PATCH evolve-ext-V2] inhibit: move transaction wrapping outside of repo setup

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Jun 16 13:30:39 CDT 2015

On 06/16/2015 11:17 AM, Laurent Charignon wrote:
> # HG changeset patch
> # User Laurent Charignon <lcharignon at fb.com>
> # Date 1434474471 25200
> #      Tue Jun 16 10:07:51 2015 -0700
> # Node ID c203f07c665e960f348b7b4f0a947565f15a8c22
> # Parent  5c13945b32fc4bcb4998a1bdd0b669ac43c26574
> inhibit: move transaction wrapping outside of repo setup
> Before this patch, transaction wrapping code was done in reposetup. It happened
> to cause stackoverflows in repos with a lot of subreps.
> This patch moves the wrapping to extsetup and avoids this problem.

Actually the issue here is that we are hackily wrapper the base class 
method instead of adding a repo class as other extensions do.

eg: https://selenic.com/hg/file/a69983942fb4/hgext/keyword.py#l594

In addition of fixing this bug, it will properly restrict the feature to 
the repository it is enabled for.

I've pushed this patch to make the topic move forward. (buit we should 
do the above)

Pierre-Yves David

More information about the Mercurial-devel mailing list