[PATCH] verify: clarify misleading fncache message

Matt Mackall mpm at selenic.com
Fri Jun 19 16:55:55 CDT 2015


On Fri, 2015-06-19 at 19:58 +0200, Adrian Buehlmann wrote:
> On 2015-06-19 19:00, Matt Mackall wrote:
> > # HG changeset patch
> > # User Matt Mackall <mpm at selenic.com>
> > # Date 1434733206 18000
> > #      Fri Jun 19 12:00:06 2015 -0500
> > # Node ID c1ad1589a44b519411b6f209c1e81322f4ccfd4e
> > # Parent  85294076adceb3263056e366023cba2e88ace6ca
> > verify: clarify misleading fncache message

> I agree that "missing revlog" for the case where the fncache file lacks
> entries, is less than ideal.

Ok, I've queued this, thanks.

> Demoting such a case to a warning is probably justified.
> 
> Remark: I think that if the fncache file in a repo A lacks entries,
> using A as the source in a 'hg clone --uncompressed' (for example) will
> then produce a repo B which indeed has missing revlogs. 'hg verify' on B
> will then fail.

Yep. We should probably have a debug command which can rebuild this file
from changelog metadata and add a hint to verify to use it.

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial-devel mailing list