[PATCH 2 of 2] revsetbenchmark: do not abort on failure to run a revset

Pierre-Yves David pierre-yves.david at ens-lyon.org
Mon Jun 22 12:12:46 CDT 2015



On 06/22/2015 07:23 AM, Augie Fackler wrote:
> On Sat, Jun 20, 2015 at 08:38:43PM -0700, Pierre-Yves David wrote:
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david at fb.com>
>> # Date 1434842530 25200
>> #      Sat Jun 20 16:22:10 2015 -0700
>> # Node ID da62bc192d63021803097a267d48e66f9f64e9fe
>> # Parent  75305531b0c92e31b35a3357774597ac78b1a1fd
>> revsetbenchmark: do not abort on failure to run a revset
>>
>> Instead of aborting the whole process, we just skip entry for revset that
>> failed to run.
>
> I'm not super-thrilled with this. Could we be capturing the error
> output somehow?

Meh, the error output is alreay forwarded to the stderr when we try to 
run the revsets, and this is "good enough" for now. We will not reused 
the error output in the result summary because it is will never fit in 
any column.

As we currently have no user to capture it, we don't. It is simple 
enough to capture it when we need it later.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list