[PATCH 3 of 5] import-checker: establish modern import convention

Gregory Szorc gregory.szorc at gmail.com
Sun Jun 28 15:15:06 CDT 2015


On Sun, Jun 28, 2015 at 12:49 PM, Gregory Szorc <gregory.szorc at gmail.com>
wrote:

> # HG changeset patch
> # User Gregory Szorc <gregory.szorc at gmail.com>
> # Date 1435520794 25200
> #      Sun Jun 28 12:46:34 2015 -0700
> # Node ID f8efa4e8b9358d8a33d1701a49b5afb5574d12a4
> # Parent  e2b71702d2baf1218c791d2ff5718b6c44abc7f4
> import-checker: establish modern import convention
>
>
This convention is a bit different from what mpm wrote at
http://pastebin.com/7fFQ0BNr. After he posted that, there was some IRC
conversation about things like lexical sorting and one import per line. I
figured things have developed to the point where *something* can be put in
code form and we can discuss more formally via code review.

The convention submitted is what I personally would like. It's pretty
comprehensive and doesn't leave much wiggle room. Yet it is also pretty
straightforward and easy to conform to. I'm pretty sure Augie's preferences
align pretty closely with this as well, although he should probably weigh
in just to be sure.

Let the bikeshedding begin.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20150628/a15c5274/attachment.html>


More information about the Mercurial-devel mailing list