[Bug 4739] New: wireproto batching appears to corrupt data when a response contains a semicolon

[mercurial-bugs at selenic.com]

http://bz.selenic.com/show_bug.cgi?id=4739

          Priority: normal
            Bug ID: 4739
                CC: mercurial-devel at selenic.com
          Assignee: bugzilla at selenic.com
           Summary: wireproto batching appears to corrupt data when a
                    response contains a semicolon
          Severity: bug
    Classification: Unclassified
                OS: All
          Reporter: durin42 at gmail.com
          Hardware: All
            Status: UNCONFIRMED
           Version: default branch
         Component: Mercurial
           Product: Mercurial

I'm working on a new wireproto command for remotefilelog that will work with
batchable. I was getting mysterious test failures when I migrated to using a
batch instead of fetching one file at a time, and it looks like I got lucky in
that the lz4-compressed data triggered this problem.

http://hg.durin42.com/remotefilelog-wip/rev/5a53cc30923c

If I wrap the data in binascii.hexlify() in my server method and then use
binascii.unhexlify() when I get it on the client, the problem goes away. I'll
try and produce a reduced test case involving a branchmap containing a ; later,
but wanted to capture the bug before I lost any mental state.

-- 
You are receiving this mail because:
You are on the CC list for the bug.