[PATCH V2] revset: fix a crash in parents() when 'wdir()' is in the set

Matt Harbison mharbison72 at gmail.com
Tue Jun 30 21:34:15 CDT 2015


On Tue, 30 Jun 2015 15:15:35 -0400, Matt Mackall <mpm at selenic.com> wrote:

> On Tue, 2015-06-30 at 10:26 -0400, Matt Harbison wrote:
>> # HG changeset patch
>> # User Matt Harbison <matt_harbison at yahoo.com>
>> # Date 1435588496 14400
>> #      Mon Jun 29 10:34:56 2015 -0400
>> # Node ID b84b980cf15bdda20c474f8f5ff6b3e367164f7e
>> # Parent  ff5172c830022b64cc5bd1bae36b2276e9dc6e5d
>> revset: fix a crash in parents() when 'wdir()' is in the set
>
> This one's queued for default, thanks.
>
> FYI, we've now got breakage in test-subrepo-deep-nested-change.t in this
> area. The calculation of changessince in archive explodes due to trying
> to use repo.revs("%d") on a workingctx. I've got a patch to add a %c
> revset.formatspec that knows how to take a context object and turn it
> into a rev or 'wdir()', but this isn't quite sufficient because ::wdir()
> doesn't work and wdir()^ has the same bug as parents().

My plan is to finish the keyword Yuya and I have been debating, and then  
switch the archive code to that is possible to avoid a copy/paste.

I've also got a series that fixes wdir()^, among other things.  I fixed a  
crash in ::wdir(), but need more investigation because wdir() doesn't show  
in the series.


More information about the Mercurial-devel mailing list