[PATCH 6 of 6] revset: fix a crash with 'roots(wdir())'
mharbison72 at gmail.com
Tue Jun 30 22:31:32 CDT 2015
On Tue, 30 Jun 2015 23:24:32 -0400, Pierre-Yves David
<pierre-yves.david at ens-lyon.org> wrote:
> On 06/30/2015 07:56 PM, Matt Harbison wrote:
>> # HG changeset patch
>> # User Matt Harbison <matt_harbison at yahoo.com>
>> # Date 1435715342 14400
>> # Tue Jun 30 21:49:02 2015 -0400
>> # Node ID c3aecbbe50596e54402e4bd98931d33f1b2d5d01
>> # Parent e26c2caf800020627f58e45f799ce932c6aee761
>> revset: fix a crash with 'roots(wdir())'
> This series worries me about two things:
> 1) performance impact, can we get than benchmarked
I've seen you do benchmarking patches before, but admittedly didn't pay
much attention to what you were doing or how to benchmark. Can you point
me to some specific steps to perform?
> 2) this is a lot of churn using None, could we settle for another value
> (max int) and move toward that instead?
More information about the Mercurial-devel