[PATCH 3 of 3] largefiles: handle logging from outside the repo
Matt Harbison
mharbison72 at gmail.com
Thu Mar 5 22:23:58 CST 2015
On Thu, 05 Mar 2015 21:04:34 -0500, Matt Mackall <mpm at selenic.com> wrote:
> On Thu, 2015-03-05 at 20:58 -0500, Matt Harbison wrote:
>> On Thu, 05 Mar 2015 14:27:06 -0500, Matt Mackall <mpm at selenic.com>
>> wrote:
>>
>> > On Tue, 2015-03-03 at 23:57 -0500, Matt Harbison wrote:
>> >> # HG changeset patch
>> >> # User Matt Harbison <matt_harbison at yahoo.com>
>> >> # Date 1425252929 18000
>> >> # Sun Mar 01 18:35:29 2015 -0500
>> >> # Node ID e4a6988bbd6fdb0c4fcfcc8dbc324ec727590f2b
>> >> # Parent 4deaf73138da53d72506cc439f256cb5418bf548
>> >> largefiles: handle logging from outside the repo
>> >
>> > These are queued for default, thanks. I added a "# no-msys" hint to
>> > check-code and cleaned up patch 2.
>> >
>>
>> OK, thanks. Any thoughts 'glob:a*' seeing the rename of file 'a' ->
>> 'b',
>> but an explicit path 'a' doesn't? (See the test-log.t change in
>> 13c1e66f9653, and the test immediately above the change.)
>
> Seems wrong.
What is happening here is that 'glob:*' causes match.anypats() to be True,
which triggers the slow path, which uses the file() revset. An explicit
path uses filelog(), unless --remove is specified on the command line
(which forces the slow path).
Now that I understand what is going on, I see there is a note in 'hg help
log' that mentions "may omit duplicate changes, removals and mode changes"
for performance reasons without --remove, so I'll leave it alone.
--Matt
More information about the Mercurial-devel
mailing list