[PATCH hglib] hglib: Wrap all application string literals in util.b() (issue4520)

Brett Cannon brett at python.org
Mon Mar 9 16:27:59 CDT 2015


On Mon, Mar 9, 2015 at 4:16 PM Matt Mackall <mpm at selenic.com> wrote:

> On Sun, 2015-03-08 at 13:08 -0400, Brett Cannon wrote:
> > # HG changeset patch
> > # User Brett Cannon <brett at python.org>
> > # Date 1425834517 14400
> > #      Sun Mar 08 13:08:37 2015 -0400
> > # Node ID 06babaeea98aaa7c58502bf3d9879fac72fd8d46
> > # Parent  ea80bd2775f6612399eb3aedf2444fcb11b0cf8a
> > hglib: Wrap all application string literals in util.b() (issue4520)
>
> This is queued for hglib, thanks. I made a few tweaks:
>
> - summary caps
> - drop stray whitespace changes
> - fix some overlong lines
>
> I can't tell you how much str(someinteger).encode('latin1') pains me
> though. I think we're going to need another helper for that.
>
> Also, I think we'll want to do "b = str" on 2.x for performance.
>

SGTM. I'll work those changes into a patch at some point (probably easier
for me to get all the changes I have queued in my local copy in first and
then do a cleanup pass after).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20150309/7e32ee15/attachment.html>


More information about the Mercurial-devel mailing list